Merged
Conversation
lvhan028
reviewed
Sep 10, 2025
lvhan028
reviewed
Sep 10, 2025
lvhan028
reviewed
Sep 10, 2025
lvhan028
reviewed
Sep 10, 2025
lvhan028
reviewed
Sep 10, 2025
lmdeploy/pytorch/models/internvl.py
Outdated
|
|
||
| def mlp_block(in_dim, out_dim): | ||
| return nn.Sequential( | ||
| nn.Linear(in_dim, out_dim), |
Collaborator
There was a problem hiding this comment.
Any reason for not using build_rowwise_linear and build_colwise_linear?
Collaborator
Author
There was a problem hiding this comment.
https://github.com/InternLM/lmdeploy/blob/main/lmdeploy/pytorch/models/internvl.py#L368
We can. But similar to the above code, as the vision encoding is only executed for once, and also for simplicity, I do not replace it with a custom op.
If you think it's worthwhile to do, I will replace them
lvhan028
reviewed
Sep 10, 2025
lvhan028
reviewed
Sep 10, 2025
lvhan028
reviewed
Sep 10, 2025
lvhan028
reviewed
Sep 10, 2025
lvhan028
reviewed
Sep 10, 2025
lvhan028
reviewed
Sep 10, 2025
lvhan028
reviewed
Sep 10, 2025
grimoire
approved these changes
Sep 17, 2025
Collaborator
|
@grimoire may resolve the following warning in PR #3922 |
lvhan028
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance & Acc
Test with VLMEvalKit, dataset: ORCBench
InternVL3.5-FLash acc details
Related